Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create New Skeleton "skeleton-tf-root-module" #48

Open
3 tasks
mcdonnnj opened this issue May 28, 2021 · 2 comments
Open
3 tasks

Create New Skeleton "skeleton-tf-root-module" #48

mcdonnnj opened this issue May 28, 2021 · 2 comments
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented May 28, 2021

💡 Summary

Consider creating a new skeleton repository that either descends from cisagov/skeleton-generic or from this repo. This would focus on Terraform code that is not designed for reuse as opposed to the goal of this skeleton.

Motivation and context

We have been using this skeleton for anything Terraform related and it has worked, but the workflows for Terraform modules and Terraform deployments have core differences. Creating a new skeleton-tf-root-module repository would allow Terraform deployment related standards to be represented in a skeleton instead of needing to look across existing deployment repositories to figure out what files need to be added (at minimum) as well as how things look across such projects in our organization.

Implementation notes

Ideally once this new skeleton is created we would, over time, migrate any Terraform code repositories that are not designed to be importable modules to descend from this new skeleton. Then any future Terraform with similar design goals would start from the new skeleton instead of this repository.

Acceptance criteria

  • New repository is created
  • Dev team signs off on the Initial Commits Pull Request
  • (OPTIONAL) Existing Terraform deployment repositories are migrated to use this new skeleton
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 28, 2021
@jsf9k
Copy link
Member

jsf9k commented May 29, 2021

The handling of default tags by the actual Terraform module and the example code in #49 highlights another place where cisagov/skeleton-tf-module and the new skeleton repository that @mcdonnnj is proposing would differ. I was a little meh about the need for a separate repo, but this has pushed me toward heartier support of this addition.

@mcdonnnj mcdonnnj changed the title Create New Skeleton "skeleton-tf-deployment" Create New Skeleton "skeleton-tf-root-module" May 31, 2021
@mcdonnnj
Copy link
Member Author

Updated the proposed skeleton name to mirror the language used by Terraform as was pointed out to me by @jsf9k 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

2 participants