Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error logging on domain and portfolios invitations #3401

Open
2 tasks
Tracked by #3402
abroddrick opened this issue Jan 24, 2025 · 0 comments
Open
2 tasks
Tracked by #3402

Fix error logging on domain and portfolios invitations #3401

abroddrick opened this issue Jan 24, 2025 · 0 comments
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team Feature: 🏢 Org Model

Comments

@abroddrick
Copy link
Contributor

Issue description

When adding a domain manager, system attempts to send emails to all existing domain managers before updating registrar.
If any of the emails to existing domain managers fails, the entire action fails midstream blocking the domain invitation. This will be handled in another bug ticket however, when running into this scenario on getgov-development, we found out that the error handling had it's own bug:
the traceback was not logged at all and we couldn't trace the cause of why email sending worked for some managers and not this particular domain manager.

It appears the error handling added around invitations needs to be altered to insure tracebacks are logged and helpful information is provided to the person debugging.

Acceptance criteria

  • all domain invitation and portfolio invitation error log the traceback successfully
  • if easy to do: The current error message says "Could not send email invitation." is updated so that it indicates if a domain invitation or the portfolio invitation failed.

Additional context

No response

Links to other issues

No response

@abroddrick abroddrick added the dev issue is for the dev team label Jan 24, 2025
@abroddrick abroddrick added bundled Parent ticket will be sprinted and this ticket is included in the parent Feature: 🏢 Org Model labels Jan 24, 2025
@abroddrick abroddrick moved this from 👶 New to 🎯 Ready in .gov Product Board Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundled Parent ticket will be sprinted and this ticket is included in the parent dev issue is for the dev team Feature: 🏢 Org Model
Projects
Status: 🎯 Ready
Development

No branches or pull requests

1 participant