Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduplicate generic type arguments #530

Closed
kkourt opened this issue Nov 4, 2022 · 8 comments · May be fixed by #2060
Closed

deduplicate generic type arguments #530

kkourt opened this issue Nov 4, 2022 · 8 comments · May be fixed by #2060
Labels
good first issue Good for newcomers

Comments

@kkourt
Copy link
Contributor

kkourt commented Nov 4, 2022

There are two versions of generic type arguments:

const (
GenericIntType = 1
GenericCharBuffer = 2
GenericCharIovec = 3
GenericSizeType = 4
GenericSkbType = 5
GenericStringType = 6
GenericSockType = 7
GenericCredType = 8
GenericS64Type = 10
GenericU64Type = 11
GenericS32Type = 12
GenericU32Type = 13
GenericFilenameType = 14
GenericPathType = 15
GenericFileType = 16
GenericFdType = 17
// GenericConstBuffer is a buffer type whose size is static (and known).
GenericConstBuffer = 18
GenericBpfAttr = 19
GenericPerfEvent = 20
GenericBpfMap = 21
GenericUserNamespace = 22
GenericCapability = 23
GenericNopType = -1
GenericInvalidType = -2
)

And

const (
argTypeInt = 1
argTypeCharBuf = 2
argTypeCharIovec = 3
argTypeSizet = 4
argTypeSkb = 5
argTypeString = 6
argTypeSock = 7
argTypeS64 = 10
argTypeU64 = 11
argTypeS32 = 12
argTypeU32 = 13
argTypeFile = 16
argTypeFd = 17
argTypeUrl = 18
argTypeFqdn = 19
)

There seem to already be conflicts, so we should deduplicate them.

@kkourt kkourt added the good first issue Good for newcomers label Nov 4, 2022
@rajaSahil
Copy link

Hey @kkourt Can I work on this issue? I am pretty new to tetragon, this would be good first issue for me.

@kkourt
Copy link
Contributor Author

kkourt commented Dec 15, 2022

Hi @rajaSahil,

Go ahead if you want. I'm not aware of someone else working on it at the moment.
Thanks!

@SumaiyaSafdar
Copy link

hey @kkourt can i work on this issue

@kkourt
Copy link
Contributor Author

kkourt commented May 30, 2023

Hi @SumaiyaSafdar. Please sync with @rajaSahil.

@mtardy
Copy link
Member

mtardy commented May 30, 2023

For info there is potential progress here #696 but no response from the author yet.

@mtardy
Copy link
Member

mtardy commented Jan 15, 2024

There was a first attempt here #696 that was abandoned, I'll close the PR for now but this can be of inspiration for someone that wants to complete that :)

h3x-eilidh added a commit to h3x-eilidh/tetragon that referenced this issue Feb 2, 2024
There are two versions of the same generic type arguments currently in use.

This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class.

Fixes: cilium#530

Signed-off-by: Luigi De Matteis <[email protected]>
h3x-eilidh added a commit to h3x-eilidh/tetragon that referenced this issue Feb 2, 2024
There are two versions of the same generic type arguments currently in use.

This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class.

Fixes: cilium#530

Signed-off-by: Luigi De Matteis <[email protected]>
h3x-eilidh added a commit to h3x-eilidh/tetragon that referenced this issue Feb 12, 2024
There are two versions of the same generic type arguments currently in use.

This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class.

Fixes: cilium#530

Signed-off-by: Luigi De Matteis <[email protected]>
@Trung-DV
Copy link
Contributor

Trung-DV commented Apr 22, 2024

This issue already solved by PR #2168

@mtardy
Copy link
Member

mtardy commented Apr 22, 2024

Indeed thanks!

@mtardy mtardy closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
6 participants