-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deduplicate generic type arguments #530
Comments
Hey @kkourt Can I work on this issue? I am pretty new to tetragon, this would be good first issue for me. |
Hi @rajaSahil, Go ahead if you want. I'm not aware of someone else working on it at the moment. |
hey @kkourt can i work on this issue |
Hi @SumaiyaSafdar. Please sync with @rajaSahil. |
For info there is potential progress here #696 but no response from the author yet. |
There was a first attempt here #696 that was abandoned, I'll close the PR for now but this can be of inspiration for someone that wants to complete that :) |
There are two versions of the same generic type arguments currently in use. This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class. Fixes: cilium#530 Signed-off-by: Luigi De Matteis <[email protected]>
There are two versions of the same generic type arguments currently in use. This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class. Fixes: cilium#530 Signed-off-by: Luigi De Matteis <[email protected]>
There are two versions of the same generic type arguments currently in use. This patch unifies them by bringing all arguments into the pkg/generictypes/generictypes.go class. Fixes: cilium#530 Signed-off-by: Luigi De Matteis <[email protected]>
This issue already solved by PR #2168 |
Indeed thanks! |
There are two versions of generic type arguments:
tetragon/pkg/generictypes/generictypes.go
Lines 6 to 36 in 3076ae7
And
tetragon/pkg/selectors/kernel.go
Lines 140 to 159 in 3076ae7
There seem to already be conflicts, so we should deduplicate them.
The text was updated successfully, but these errors were encountered: