From b681b88ad00c8a38664b12846678e70028b219e0 Mon Sep 17 00:00:00 2001 From: Kornilios Kourtis Date: Fri, 13 Dec 2024 13:55:53 +0100 Subject: [PATCH] gh: validate crd: be less strict The validate CRD action checks two things: whether yaml files were changed without the version being updated, and whether the version was updated without changing the yaml files. There are legitimate reasons for doing the second (e.g., when we do a releas and bump the minor number) so remove the check. Signed-off-by: Kornilios Kourtis --- .github/workflows/validate-crd.yaml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/validate-crd.yaml b/.github/workflows/validate-crd.yaml index 89a4669cca5..a75fdc006dd 100644 --- a/.github/workflows/validate-crd.yaml +++ b/.github/workflows/validate-crd.yaml @@ -43,8 +43,3 @@ jobs: echo "Changes to the files pkg/k8s/apis/cilium.io/client/crds/v1alpha1/*.yaml requires CustomResourceDefinitionSchemaVersion to be updated in pkg/k8s/apis/cilium.io/v1alpha1/version.go" exit 1 fi - - if [ "$crd_changed" -eq 0 ] && [ "$version_changed" -eq 1 ]; then - echo "CustomResourceDefinitionSchemaVersion in pkg/k8s/apis/cilium.io/v1alpha1/version.go to be updated only in case of modifying the files pkg/k8s/apis/cilium.io/client/crds/v1alpha1/*.yaml" - exit 1 - fi