collection: Add Assign method #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like unrelated CI failure |
lmb
reviewed
Aug 15, 2023
|
CI was my fault, sorry |
Assign() bridges bpf2go generated code and functionality implemented in Collection. A few things are easier to do in Collection, like iterating through maps and programs. It is harder to guarantee invariants like map and program initialization using reflection as well as being more complicated. Signed-off-by: Daniel Xu <[email protected]>
Signed-off-by: Daniel Xu <[email protected]>
|
Sorry for the long delay, this slipped my radar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assign() bridges bpf2go generated code and functionality implemented in
Collection. A few things are easier to do in Collection, like iterating
through maps and programs. It is harder to guarantee invariants like map
and program initialization using reflection as well as being more
complicated.
Signed-off-by: Daniel Xu [email protected]