Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Should MixpanelEngage.Engage be private ? #16

Open
joaojeronimo opened this issue Dec 10, 2014 · 1 comment
Open

Should MixpanelEngage.Engage be private ? #16

joaojeronimo opened this issue Dec 10, 2014 · 1 comment

Comments

@joaojeronimo
Copy link

Should MixpanelEngage.Engage defined here be a private method ?
@chrisnicola
Copy link
Owner

It's been a while but yes I believe it is called using the Set and Increment methods. However it could arguably be protected in case someone wants to override it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisnicola @joaojeronimo