Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fatal potential error]image_beauty using incorrect parameter #479

Open
YacratesWyh opened this issue Jan 15, 2025 · 1 comment
Open

[fatal potential error]image_beauty using incorrect parameter #479

YacratesWyh opened this issue Jan 15, 2025 · 1 comment

Comments

@YacratesWyh
Copy link

sigmaColor = int((image.width + image.height) / 256 * factor)
In image_beauty you use bilateralfilter, while sigma is deviation as double instead of int.
plus, it could not be 0 or under 0

@YacratesWyh YacratesWyh changed the title [fatal potential error] [fatal potential error]image_beauty using incorrect parameter Jan 15, 2025
@chflame163
Copy link
Owner

Thank you for pointing out the mistake. Now modify to:

sigmaColor = max(1, float((image.width + image.height) / 256 * factor))
sigmaSpace = max(1, float((image.width + image.height) / 160 * factor))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants