Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python 3.11 support #212

Open
sven-ruess opened this issue Dec 19, 2024 · 5 comments
Open

Removed Python 3.11 support #212

sven-ruess opened this issue Dec 19, 2024 · 5 comments

Comments

@sven-ruess
Copy link
Contributor

Describe the bug
Current package version is only supporting Python >= 3.12.

To Reproduce
I just wanted to update my old package 0.6.1 to 0.8.0 and I get a message, that this version is not supported.

Additional context
Is there a special reason, why the support is removed?
Python 3.11 is supported until 2027-10 with security patches. I can not update to a newer Python version. I need this package running under 3.11.

@sven-ruess sven-ruess added the bug Something isn't working label Dec 19, 2024
@chemelli74
Copy link
Owner

The library is focused on HomeAssistant, that is based on 3.12 and in a while 3.13.

You can always try to readd support for 3.11 and see how many code changes are needed.

@sven-ruess
Copy link
Contributor Author

I readded Python 3.11 support. There are no code changes needed. I can understand, that you follow HomeAssistant Python3 support strategy. But it is a standalone library and can be used without HomeAssistant. For those people it will be great, if a wider range of Python3 versions are supported. That is no problem for HomeAssistant. There you specify which version you want and all dependencies are resolved for Python version specified.

I will use this library to integrate monitoring for Vodafone Stations in two monitoring different monitoring software versions. Those projects are not so fast with change Python versions. So it will be helpful, to have support for Python >=3.10 support. Otherwise I have to create my own library. That is not what I want to do.

I will support you to enhance this library and take care about, that is running, if there are firmware updates or API changes. So lets work together on one library instead of two.

@chemelli74 chemelli74 added python and removed bug Something isn't working labels Dec 23, 2024
@chemelli74
Copy link
Owner

Will accept a PR to reintroduce py311 support.

@sven-ruess
Copy link
Contributor Author

Okay. So what should I do?

  • Adapt pyproject.toml to accept Python 3.11 again?

Then the new package can be installed on Python 3.11 again.
This is the easy way.

Testing:

  • Setup new container for testing with Python 3.11?

I am not sure, how to do it. I was playing a little bit, but was not able to create a new container, with Python 3.11 environment, that is able to run library test directly.

@sven-ruess
Copy link
Contributor Author

I have created #215 for this. Hopefully I have done all necessary tasks.

@github-actions github-actions bot removed the python label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants