-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jwt is invalid after #255 #281
Comments
seeing in this example it's hitting ::1, i've had mixed results with ipv6 to begin with but in my original testing where i hit this bug i was either using 127.0.0.1, my exact ipv4 ip, or my tailnet dns address which i think is ipv4. |
this is at least also true when using wsl ubuntu 22 for both client and server sides OS [e.g. Ubuntu, macOS]
|
Seeing the same problem on ubuntu 22 with a fresh install. |
@caarlos0 if you have time i'd like to help resolve this if i can. do you have any suggestions for what might be needed? this has been a blocker for me for a little bit and i have just now gotten back around to looking at it. |
maybe it's something else? i tried building from the latest release even and i'm not able to connect to localhost anymore idk what changed. |
refs #281 Signed-off-by: Carlos Alexandro Becker <[email protected]>
hey, sorry for the delay, #286 should fix it! |
you're a lifesaver! thank you so much!! testing now 🤓 |
it works!! thank you again!! my intuition is that the change made it try to use rsa key type instead of eddsa/ed25519? that was as far as i'd kinda figured out, but looking at the pr, i think i'd have been stuck a long time before figuring out how to fix without just fully reverting the whole thing. thanks again 👍 |
* fix: jwks validation using the wrong type refs #281 Signed-off-by: Carlos Alexandro Becker <[email protected]> * chore: var name --------- Signed-off-by: Carlos Alexandro Becker <[email protected]>
Describe the bug
commits after #255 fail to connect correctly with
charm serve
probably relates to specifically #253 but relates to #252 #254 too
i've been using commits since this just fine,
recently i got a fresh windows install,
so maybe my go.work or other deps in my old box allowed me not to see this issue,
i haven't tried on linux yet, but i had been using this code on both windows and linux for a while now.
with no charm environment variables set and only using commits from charmbracelet/charm:
when running using commit
47448ea
everything works
with no charm environment variables set and only using commits from charmbracelet/charm:
when running using commit
a2f77b8
FAIL: jwt is invalid
The text was updated successfully, but these errors were encountered: