From 7cd38687a60b7a3ad1e9d6187701457d7fd6e236 Mon Sep 17 00:00:00 2001 From: Ahmad Rezaii Date: Wed, 8 Jan 2025 19:52:54 -0700 Subject: [PATCH] update comment wording Signed-off-by: Ahmad Rezaii --- frontend/lib/resolution/Resolver.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/frontend/lib/resolution/Resolver.cpp b/frontend/lib/resolution/Resolver.cpp index 928039b16311..1dceb2e7bddc 100644 --- a/frontend/lib/resolution/Resolver.cpp +++ b/frontend/lib/resolution/Resolver.cpp @@ -951,8 +951,8 @@ handleRejectedCandidates(Context* context, std::vector& rejected, const resolution::CallInfo& ci, const uast::Call*& call) { - // There were candidates but we threw them out. We can issue a nicer - // error explaining why each candidate was rejected. + // By performing some processing in the resolver, we can issue a nicer error + // explaining why each candidate was rejected. std::vector badPasses; std::vector actualDecls; badPasses.resize(rejected.size()); @@ -961,8 +961,8 @@ handleRejectedCandidates(Context* context, for (size_t i = 0; i < rejected.size(); i++) { auto &candidate = rejected[i]; if (candidate.reason() == resolution::FAIL_CANNOT_PASS && - /* skip printing detailed info_ here because computing the formal-actual - map will go poorly with an unknown formal. */ + /* skip computing the formal-actual map because it will go poorly + with an unknown formal. */ candidate.formalReason() != resolution::FAIL_UNKNOWN_FORMAL_TYPE) { auto fn = candidate.initialForErr(); resolution::FormalActualMap fa(fn, ci); @@ -1996,6 +1996,7 @@ void Resolver::handleResolvedCallPrintCandidates(ResolvedExpression& r, } if (!rejected.empty()) { + // There were candidates but we threw them out. Report on those. handleRejectedCandidates(context, byPostorder, rejected, ci, call); return; }