Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability to add update properties #295

Open
decelc-pivotal opened this issue Jan 8, 2019 · 1 comment
Open

Remove the ability to add update properties #295

decelc-pivotal opened this issue Jan 8, 2019 · 1 comment

Comments

@decelc-pivotal
Copy link

A tile developer can define update properties:

  canaries: 2
  canary_watch_time: 3600000-7200000
  max_in_flight: 10
  update_watch_time: 3600000-7200000

but they get overwritten by Ops Mgr when the tile is installed - https://github.com/pivotal-cf/installation/blob/master/web/app/models/tempest/manifests/product_manifest_generator.rb#L223-L232

def update_section
     {
       'canaries' => 1,
       'canary_watch_time' => '30000-300000',
       'update_watch_time' => '30000-300000',
       'max_in_flight' => 1,
       'max_errors' => 2,
       'serial' => @product.template.serial,
     }
end

We should remove the ability of adding these properties.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants