Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade solidity-ibc-eureka commit #123

Open
rootulp opened this issue Feb 3, 2025 · 0 comments
Open

Upgrade solidity-ibc-eureka commit #123

rootulp opened this issue Feb 3, 2025 · 0 comments

Comments

@rootulp
Copy link
Collaborator

rootulp commented Feb 3, 2025

Context

#122 upgrades to SP1 v4 but it doesn't upgrade the solidity-ibc-eureka submodule commit because that involved a number of breaking changes.

Proposal

Upgrade the solidity-ibc-eureka commit. To reduce the diff, we can consider not upgrading to Cosmos SDK v0.52.x by copying the Go code that we need from solidity-ibc-eureka directly into this repo and removing and Go dependencies so that we don't transitively get bumped to v0.52.x.
@rootulp rootulp mentioned this issue Feb 3, 2025
Merged
rootulp added a commit that referenced this issue Feb 3, 2025
@rootulp
chore(deps): upgrade to sp1 v4 (#122)
7210579 
FLUP to #106
because we use a root level Cargo workspace for celestia-prover. See
#109

Closes #111
Opens #123

## Testing

```
cargo build
```

passes in root (for celestia-prover) and in `provers/blevm`.

## Notice

Contributors to this repo will have to modify their local `.env` file
and bump to the latest Rust and SP1 versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rootulp