Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move root level elfs and programs into celestia-prover #109

Closed
rootulp opened this issue Jan 28, 2025 · 1 comment · Fixed by #135
Closed

Move root level elfs and programs into celestia-prover #109

rootulp opened this issue Jan 28, 2025 · 1 comment · Fixed by #135
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 28, 2025

Context

We have multiple Rust workspaces and they aren't organized coherently.

The celestia-prover workspace uses Cargo.toml defined in the root: https://github.com/celestiaorg/celestia-zkevm-ibc-demo/blob/main/Cargo.toml

The blevm workspace uses Cargo.toml defined in provers/blevm: https://github.com/celestiaorg/celestia-zkevm-ibc-demo/blob/main/provers/blevm/Cargo.lock

Problem

It's confusing that elfs for the celestia-prover are in the root. Also SP1 programs for celestia-prover are in programs/ when I would expect them to be inside provers/celestia-prover/

Proposal

  1. Move the root level Cargo.toml inside provers/celestia-prover
  2. Move the root level elfs directory inside provers/celestia-prover
  3. Move the root level programs directory inside provers/celestia-prover
This was referenced Jan 28, 2025
Closed
Open
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Feb 3, 2025

Alternative to step 1 of this proposal is to use a root level workspace-wide Cargo file as suggested in #116

rootulp added a commit that referenced this issue Feb 3, 2025
@rootulp
chore(deps): upgrade to sp1 v4 (#122)
7210579 
FLUP to #106
because we use a root level Cargo workspace for celestia-prover. See
#109

Closes #111
Opens #123

## Testing

```
cargo build
```

passes in root (for celestia-prover) and in `provers/blevm`.

## Notice

Contributors to this repo will have to modify their local `.env` file
and bump to the latest Rust and SP1 versions.
@rootulp rootulp self-assigned this Feb 5, 2025
@rootulp rootulp mentioned this issue Feb 5, 2025
Merged
rootulp added a commit that referenced this issue Feb 5, 2025
@rootulp
refactor: consolidate celestia-prover (#135)
44c7893 
Closes #109

## Testing

```
$ cargo run -p celestia-prover
```

starts the server and I can query verifier keys:

```
$     grpcurl -plaintext localhost:50051 celestia.prover.v1.Prover/Info
{
  "stateTransitionVerifierKey": "0x007279d4076a55500ad2d12fbcb6e336958713327a6020417094a5210eb4d455",
  "stateMembershipVerifierKey": "0x003e36b7393697dd4a69cf0c660974825932095295a4fbbe0bab7982dfbffda7"
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: consolidate celestia-prover rootulp/celestia-zkevm-ibc-demo
1 participant
@rootulp