Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milkcheck should advise the user #29

Open
wilfriedroset opened this issue Oct 6, 2015 · 0 comments
Open

Milkcheck should advise the user #29

wilfriedroset opened this issue Oct 6, 2015 · 0 comments

Comments

@wilfriedroset
Copy link

When somes targets are failed after a run of Milkcheck, the user need the report/summary of the command and then he has to decide what to do. Milkcheck should provide a feature allowing the user to define a comment for each comment. This comment would be displayed to the user when a target is failed.

services:
    svc1:
        desc: verify %SERVICE
        target: "node[1-10]"
        actions:
            status:
                cmd: service %SERVICE status
                fix: service %SERVICE start

Let's say that node[2,7] doesn't have svc1 running, Milkcheck would display the advice:

--8<--
 SUMMARY - 1 action (1 failed)
 + svc1.status                                                          
        svc1 NOK, try clush -bw node[2,7] service svc1 start

If we were pushing the idea a little bit further, Milkcheck should provide an option (let's say --fixup). This option should execute automatically execute all fixes right after the check:

  1. service %SERVICE status (not running)
  2. service %SERVICE start (ok)
  3. service %SERVICE status (runnig)

If, after the fix was executed the service is still in error, milkcheck should set the target/service as failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants