Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit condo strata imputation #7

Open
dfsnow opened this issue Nov 2, 2023 · 2 comments
Open

Revisit condo strata imputation #7

dfsnow opened this issue Nov 2, 2023 · 2 comments
Assignees
@wrridgeway
Labels
method ML technique or method change

Comments

@dfsnow
Copy link
Member

dfsnow commented Nov 2, 2023

The condo model uses recipes-based imputation for condo strata. Currently, it uses KNN using Gower's distance and a few of the most salient condo features (year built, distance, etc.). We should revisit this method considering the strata features do most of the work in the condo model and there are many condos in the City.
@dfsnow dfsnow added this to the 2024 model parity and updates milestone Dec 5, 2023
@dfsnow dfsnow added the method ML technique or method change label Dec 5, 2023
@dfsnow dfsnow removed this from the 2024 model parity and updates milestone Apr 16, 2024
@ssaurbier
Copy link

Is this issue alive? Or is #73 a new version?

@dfsnow
Copy link
Member Author

dfsnow commented Dec 22, 2024

Definitely alive! Per your own critique, the imputation method could use another look, hence the existence of this issue. I'd say this issue is (so far) largely separate from #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wrridgeway wrridgeway

Labels
method ML technique or method change
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

7-revisit-condo-strata-imputation ccao-data/model-condo-avm
3 participants
@wrridgeway @ssaurbier @dfsnow