Add price breakdowns by strata to condo pipeline report #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owns-by-strata-to-condo-pipeline-report' into 31-add-price-breakdowns-by-strata-to-condo-pipeline-report # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Damonamajor
requested review from
dfsnow,
wrridgeway and
jeancochrane
as code owners
dfsnow
changed the title
Damonamajor
commented
Jan 2, 2025
reports/performance/_outcomes.qmd
Outdated
| ::: panel-tabset | ||
|
|
||
| ```{r _outcomes_imputed_cleaning} | ||
| training_data_distinct <- training_data %>% |
There was a problem hiding this comment.
Keep only the most recent sale price
Damonamajor
commented
Jan 2, 2025
| @@ -386,3 +386,164 @@ stats_median_yoy_delta %>% | |||
| c("Comparison of YOY Change in AV for Sold and Unsold Houses" = 7) | |||
| ) | |||
| ``` | |||
|
|
|||
| ## Strata | |||
There was a problem hiding this comment.
This has to use model_fetch_run("2024-12-19-wonderful-yuxin", "2025") since strata_is_imputed is only in the runs for this year,
Damonamajor
commented
Jan 10, 2025
| ::: panel-tabset | ||
|
|
||
| ```{r _outcomes_imputed_cleaning} | ||
| strata <- assessment_pin %>% |
There was a problem hiding this comment.
Non livable spaces drastically change these charts
Damonamajor
commented
Jan 10, 2025
| left_join( | ||
| training_data %>% | ||
| arrange(desc(meta_sale_date)) %>% | ||
| distinct(meta_pin, .keep_all = TRUE) %>% |
There was a problem hiding this comment.
Keep only the most recent sale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31