Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color highlights hard to read #71

Open
codevski opened this issue Jan 27, 2025 · 6 comments
Open

Color highlights hard to read #71

codevski opened this issue Jan 27, 2025 · 6 comments
Labels
bug Something isn't working

Comments

@codevski
Copy link

Code snippet highlights are hard to see for example see screenshot for Macchiato:

Image

@tecandrew
Copy link
Collaborator

Oh, this is new to me. never realized Zed had a snippets feature. can you share your snippet and language to recreate this bug? The example from the Zed docs seem to short and appear just fine?

Image

@codevski
Copy link
Author

I think its the prediction (zed's ai completion?) possible to try that out on your setup?

@tecandrew
Copy link
Collaborator

Image

this looks fine to me? do you have any theme overrides in your settings.json? the experimental.theme_overrides key handles these.

@codevski
Copy link
Author

I have one override just to sort out my issue:

settings.json
// Zed settings
//
// For information on how to configure Zed, see the Zed
// documentation: https://zed.dev/docs/configuring-zed
//
// To see all of Zed's default settings without changing your
// custom settings, run `zed: open default settings` from the
// command palette (cmd-shift-p / ctrl-shift-p)
{
  "ssh_connections": [
    {
      "host": "xxx.xxx.xxx",
      "projects": [
        {
          "paths": ["~/lab"]
        }
      ]
    }
  ],
  "assistant": {
    "default_model": {
      "provider": "zed.dev",
      "model": "claude-3-5-sonnet-20240620"
    },
    "version": "2"
  },
  "tab_size": 2,
  "ui_font_size": 16,
  "buffer_font_size": 16,
  "theme": {
    "mode": "system",
    "light": "Catppuccin Macchiato",
    "dark": "Catppuccin Macchiato"
  },
  "experimental.theme_overrides": {
    "editor.document_highlight.bracket_background": "#dc8a7800"
  }
}

without overrides:

Image

Overrides on:

Image

One thing I notice is its only when you do them in brackets. For example if I do auto gen outside a bracket it works fine but when I start with { then new line and wait it highlights all the suggested with that color.

@tecandrew
Copy link
Collaborator

tecandrew commented Jan 31, 2025

I managed to recreate this today on a project I was working on. It's not as brown in color as your initial screenshot, but it's still not that appealing 😅

Will push a fix when I find it

Image

@tecandrew tecandrew added the bug Something isn't working label Jan 31, 2025
@codevski
Copy link
Author

Legend thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants