Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imgpkg pull time -b perf should not be influenced by number of referenced images #129

Closed
cppforlife opened this issue Apr 14, 2021 · 4 comments
Closed

imgpkg pull time -b perf should not be influenced by number of referenced images #129

cppforlife opened this issue Apr 14, 2021 · 4 comments
Assignees
@DennisDenuto
Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@cppforlife
Copy link
Contributor

Describe the problem/challenge you have

Currently imgpkg pull -b checks on every referenced image to rewrite images.yml. This may lead to slow down of imgpkg pull as bundle grows in number of referenced images. How can we decouple perf of imgpkg pull from number of referenced images.

(On a related topic, interesting use case: user is able to download bundle image but not authorized to download referenced images.)
@cppforlife cppforlife added enhancement This issue is a feature request carvel triage This issue has not yet been reviewed for validity labels Apr 14, 2021
@cppforlife cppforlife mentioned this issue Apr 20, 2021
Closed
@pivotaljohn pivotaljohn added discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution and removed carvel triage This issue has not yet been reviewed for validity labels Apr 26, 2021
@joaopapereira joaopapereira mentioned this issue Apr 29, 2021
Closed
@joaopapereira
Copy link
Member

Sounds good to me. The stepping stone for this issue will be #136 due to this issue we will be able to with 1 request per bundle understand what needs to be pulled or not.

Accepting this issue.

@joaopapereira joaopapereira added carvel accepted This issue should be considered for future work and that the triage process has been completed and removed discussion This issue is not a bug or feature and a conversation is needed to find an appropriate resolution labels Jun 1, 2021
@DennisDenuto DennisDenuto self-assigned this Jun 7, 2021
@DennisDenuto
Copy link
Contributor 

bundle is pushed
bundle was copied (no locations img because bundle was copied by older imgpkg), images with same digest exist in the bundle repository
bundle was copied + locations img exists

case bundle was copied with older imgpkg

  • if first refed img doesnt exist in bundle repository, then just use original img locations. no need to check original img locations for image existance
  • Perhaps providing a warning message to the user "please copy the bundle again to make future pulls faster"

@DennisDenuto
Copy link
Contributor

DennisDenuto commented Jun 8, 2021 •
edited
Loading

Blocked on #161

EDIT: No longer blocked

@joaopapereira
Copy link
Member

Fixed in version 0.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DennisDenuto DennisDenuto

Labels
carvel accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cppforlife @joaopapereira @DennisDenuto @pivotaljohn