-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find way to avoid wrapping dates in tables in mobile view #80
Comments
Did you fix this already? Looking at this table in Firefox's responsive mode, the issue is not very prominent anymore. |
Hi @bencomp, No, this has not been fixed. Checking on my device (an iPhone SE, which I have gotten several comments about how cute it is because it's so small), it's still an issue on Firefox and Safari mobile.
It's weirdly difficult to define how wide a table should be using markdown: https://pandoc.org/MANUAL.html#tables I think the solution may be to set the |
I should have clarified that I meant this be changed in the CSS. Looking at your screenshot I feel the gap between the columns is quite big, as well as the margins on the left and right of the table. If your phone is cute/small, better make good use of the available space! |
Ah, This turns out to be a problem with the width of the column headers: https://carpentries.github.io/sandpaper-docs/episodes.html#tables The table headers for the the first table in episode 1 are at a 2:1 ratio and quite long (which is likely from a weird bug in {tinkr} that I'm going to have to suss out). This causes the table widths to be set at 64% and 36%, respectively: <table class="table">
<colgroup>
<col width="65%">
<col width="34%">
</colgroup>
... The solution is to shorten the table widths to their original lengths |
Not sure how to do this because dates are incredibly hard to parse, but there is a situation that was found where dates wrap in mobile view: carpentries/lesson-transition#65
The text was updated successfully, but these errors were encountered: