Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase kine on top of upstream #35

Closed
lowjoel opened this issue Dec 1, 2022 · 2 comments
Closed

Rebase kine on top of upstream #35

lowjoel opened this issue Dec 1, 2022 · 2 comments

Comments

@lowjoel
Copy link

lowjoel commented Dec 1, 2022

Hey there! It seems like we're running a forked version of kine with quite a few changes. Some of them (e.g. customisable connection limits, database sizes) have already been implemented upstream. There's also some changes for correctness and performance upstream. Any chance to get the fork updated to include the latest changes from upstream?

@lowjoel
Copy link
Author

lowjoel commented Dec 1, 2022

Tried to match the commits:

canonical/kine k3s-io/kine
canonical/kine@c9734ab k3s-io/kine@95e5562
canonical/kine@4277f73 k3s-io/kine@92fcaea
canonical/kine@d47190d k3s-io/kine@1c94e77

Some were indeed cherry-picked. Wouldn't it be preferable to rely on the upstream implementation though?

@louiseschmidtgen
Copy link
Contributor

Hi @lowjoel,

Thank you for your input!

This project has diverged from kine and is now actively maintained by Canonical. If you see any feature gaps please open a separate issue.

With kind regards,
Louise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants