Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No thorough error handling on appending to the event log #139

Open
louiseschmidtgen opened this issue Jul 22, 2024 · 0 comments
Open

No thorough error handling on appending to the event log #139

louiseschmidtgen opened this issue Jul 22, 2024 · 0 comments

Comments

@louiseschmidtgen
Copy link
Contributor

We are not properly handling this error:

rev, err = l.log.Append(ctx, deleteEvent)
if err != nil {
// If error on Append we assume it's a UNIQUE constraint error, so we fetch the latest (if we can)
// and return that the delete failed

From: https://github.com/canonical/k8s-dqlite/blob/master/pkg/kine/logstructured/logstructured.go#L221

This can lead to issues as captured in: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant