Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling repository can hang execution indefinitely #933

Open
dariuszd21 opened this issue Dec 12, 2024 · 1 comment
Open

pulling repository can hang execution indefinitely #933

dariuszd21 opened this issue Dec 12, 2024 · 1 comment
Labels
Bug Something isn't working Triaged

Comments

@dariuszd21
Copy link
Contributor

dariuszd21 commented Dec 12, 2024

Bug Description

During pull phase if repository is private or does not exist, craft will hung forever waiting for the credentials.
It should immediately fail as there is no place for user to put the credentials in

To Reproduce

Build the source that requests you to use credentials (e.g. source from GitHub or Launchpad via https:// that is not public or does not exist).

part yaml

non-existing-part:
    # See 'snapcraft plugins'
    source: https://github.com/non-existing-user/non-existing-repo
    source-type: git
    plugin: nil

Relevant log output

2024-12-12 10:37:22.198 execute action my-part:Action(part_name='my-part', step=Step.PULL, action_type=ActionType.RUN, reason=None, project_vars=None, properties=ActionProperties(changed_files=None, changed_dirs=None))                  │
2024-12-12 10:37:22.199 Executing: git clone --recursive https://github.com/non-existing-user/non-existing-repo                                                                                                                             │
2024-12-12 10:37:22.201 :: Cloning into '/root/parts/my-part/src'...
@dariuszd21 dariuszd21 added Bug Something isn't working Triaged labels Dec 12, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3805.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triaged
Projects
None yet
Development

No branches or pull requests

1 participant