Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reCAPTCHA: fix style regressions in Benefits Admin #2608

Closed
2 tasks done
angela-tran opened this issue Jan 2, 2025 · 3 comments
Closed
2 tasks done

reCAPTCHA: fix style regressions in Benefits Admin #2608

angela-tran opened this issue Jan 2, 2025 · 3 comments
Assignees
Labels
front-end HTML/CSS/JavaScript and Django templates

Comments

@angela-tran
Copy link
Member

angela-tran commented Jan 2, 2025

Once #2586 and #2588 are merged in to refactor/recaptcha-copy, let's get that branch caught up with changes from main, #2555 being one of those changes.

Then we can go through Benefits Admin and clean up any regressions that came from template refactors / clean-up.

One that we know about is this one: #2586 (comment)

Acceptance Criteria

  • All pages in Benefits Admin have been checked for style regressions
  • Regressions are fixed
@angela-tran
Copy link
Member Author

A lot of these are just because refactor/recaptcha-copy was branched off main before #2555 was done.

@machikoyasuda machikoyasuda self-assigned this Jan 6, 2025
@machikoyasuda
Copy link
Member

Assigning this to myself.

@angela-tran
Copy link
Member Author

I went through the in-person enrollment flow just now on the refactor/recaptcha-copy branch, and it looks good!

#2613 was the only regression and has been fixed, so closing this ticket now

@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Services Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end HTML/CSS/JavaScript and Django templates
Projects
Status: Done
Development

No branches or pull requests

2 participants