Skip to content
This repository has been archived by the owner on Aug 15, 2024. It is now read-only.

Return error when files are missing #45

Open
ineiti opened this issue Jul 5, 2021 · 4 comments
Open

Return error when files are missing #45

ineiti opened this issue Jul 5, 2021 · 4 comments
Assignees
@ineiti

Comments

@ineiti
Copy link
Member

ineiti commented Jul 5, 2021

Currently the API will probably panic if the files are not in the directory. It should return correct errors for:

  • no directory passed (in the best case, it should just do the normal tor-thingie)
  • directory empty or not existing
  • file(s) missing
@cgrigis cgrigis assigned cgrigis and laurent-girod and unassigned cgrigis Jul 5, 2021
@wouterl
Copy link
Collaborator

wouterl commented Jul 13, 2021

Does this also properly catch if the directory is empty?

@ineiti ineiti assigned cgrigis and unassigned laurent-girod Jul 13, 2021
@wouterl
Copy link
Collaborator

wouterl commented Jul 13, 2021

@laurent-girod can you also add a small test to arti-rest itself?

@cgrigis cgrigis mentioned this issue Jul 13, 2021
Merged
@cgrigis
Copy link
Contributor

cgrigis commented Jul 13, 2021

Tests on the android side added with c4dt/lightarti-rest-android#5

@cgrigis cgrigis assigned laurent-girod and unassigned cgrigis Jul 14, 2021
@ineiti
Copy link
Member Author

ineiti commented Jul 28, 2021

iOS is failing with opaque error - needs to be fixed by @ineiti

@ineiti ineiti assigned ineiti and unassigned laurent-girod Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ineiti ineiti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ineiti @wouterl @laurent-girod @cgrigis