Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images taken in landscape mode are saved in wrong aspect ratio #40

Open
tomcatmwi opened this issue Oct 9, 2018 · 0 comments
Open

Images taken in landscape mode are saved in wrong aspect ratio #40

tomcatmwi opened this issue Oct 9, 2018 · 0 comments

Comments

@tomcatmwi
Copy link

  • CLI: 4.2.2
  • Cross-platform modules: 4.2.1
  • Runtime(s): 4.2.0
  • Plugin(s):
  "dependencies": {
    "@angular/animations": "file:../../node_modules/@angular/animations",
    "@angular/common": "file:../../node_modules/@angular/common",
    "@angular/compiler": "file:../../node_modules/@angular/compiler",
    "@angular/core": "file:../../node_modules/@angular/core",
    "@angular/forms": "file:../../node_modules/@angular/forms",
    "@angular/platform-browser": "file:../../node_modules/@angular/platform-browser",
    "@angular/platform-browser-dynamic": "file:../../node_modules/@angular/platform-browser-dynamic",
    "@angular/router": "file:../../node_modules/@angular/router",
    "@ngrx/effects": "file:../../node_modules/@ngrx/effects",
    "@ngrx/router-store": "file:../../node_modules/@ngrx/router-store",
    "@ngrx/store": "file:../../node_modules/@ngrx/store",
    "@ngx-translate/core": "file:../../node_modules/@ngx-translate/core",
    "@nrwl/nx": "file:../../node_modules/@nrwl/nx",
    "@nstudio/nativescript-camera-plus": "file:../../node_modules/@nstudio/nativescript-camera-plus",
    "@pnp/nativescript": "file:../../xplat/nativescript",
    "@pnp/nativescript-game-ar": "file:../../xplat/nativescript/plugins/nativescript-game-ar",
    "@pnp/nativescript-games": "file:../../xplat/nativescript/plugins/nativescript-games",
    "@pnp/scss": "file:../../libs/scss",
    "date-fns": "file:../../node_modules/date-fns",
    "nativescript-angular": "file:../../node_modules/nativescript-angular",
    "nativescript-audio": "file:../../node_modules/nativescript-audio",
    "nativescript-background-http": "file:../../node_modules/nativescript-background-http",
    "nativescript-cardview": "file:../../node_modules/nativescript-cardview",
    "nativescript-checkbox": "file:../../node_modules/nativescript-checkbox",
    "nativescript-downloader": "file:../../node_modules/nativescript-downloader",
    "nativescript-drop-down": "file:../../node_modules/nativescript-drop-down",
    "nativescript-exoplayer": "file:../../node_modules/nativescript-exoplayer",
    "nativescript-feedback": "file:../../node_modules/nativescript-feedback",
    "nativescript-fresco": "file:../../node_modules/nativescript-fresco",
    "nativescript-imagecropper": "file:../../node_modules/nativescript-imagecropper",
    "nativescript-imagepicker": "file:../../node_modules/nativescript-imagepicker",
    "nativescript-iqkeyboardmanager": "file:../../node_modules/nativescript-iqkeyboardmanager",
    "nativescript-loading-indicator": "file:../../node_modules/nativescript-loading-indicator",
    "nativescript-ngx-fonticon": "file:../../node_modules/nativescript-ngx-fonticon",
    "nativescript-ngx-slides": "file:../../node_modules/nativescript-ngx-slides",
    "nativescript-payments": "file:../../node_modules/nativescript-payments",
    "nativescript-permissions": "file:../../node_modules/nativescript-permissions",
    "nativescript-plugin-appsflyer": "file:../../node_modules/nativescript-plugin-appsflyer",
    "nativescript-plugin-firebase": "file:../../node_modules/nativescript-plugin-firebase",
    "nativescript-pusher": "file:../../node_modules/nativescript-pusher",
    "nativescript-shimmer": "file:../../node_modules/nativescript-shimmer",
    "nativescript-social-share": "file:../../node_modules/nativescript-social-share",
    "nativescript-theme-core": "file:../../node_modules/nativescript-theme-core",
    "nativescript-timedatepicker": "file:../../node_modules/nativescript-timedatepicker",
    "nativescript-toasts": "file:../../node_modules/nativescript-toasts",
    "nativescript-ui-listview": "file:../../xplat/nativescript/plugins/nativescript-ui-listview-3.7.1-pr69.tgz",
    "nativescript-ui-sidedrawer": "~4.3.0",
    "nativescript-zendesk-sdk": "file:../../node_modules/nativescript-zendesk-sdk",
    "reflect-metadata": "file:../../node_modules/reflect-metadata",
    "rxjs": "file:../../node_modules/rxjs",
    "rxjs-compat": "file:../../node_modules/rxjs-compat",
    "tns-core-modules": "file:../../node_modules/tns-core-modules",
    "tns-core-modules-widgets": "file:../../node_modules/tns-core-modules-widgets",
    "zone.js": "file:../../node_modules/zone.js",
    "~app-plugin-last": "file:tools/~app-plugin-last"
  },
  "devDependencies": {
    "@angular/compiler-cli": "~6.1.0",
    "@angular/language-service": "file:../../node_modules/@angular/language-service",
    "@ngtools/webpack": "~6.2.1",
    "codelyzer": "file:../../node_modules/codelyzer",
    "nativescript-dev-webpack": "~0.16.0",
    "tns-platform-declarations": "file:../../node_modules/tns-platform-declarations",
    "typescript": "file:../../node_modules/typescript"
  }

Steps to reproduce:

  1. Take a picture in landscape on iOS.
  2. Pass it to imagecropper. It will appear in the correct aspect ratio, but either rotated by 90 degrees or overflowing the edge of the screen (depending on how you passed it)
  3. Crop it and save.
  4. The image will be correctly cropped, but the aspect ratio will be wrong and therefore squeezed or stretched.
  5. Curse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant