Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto add in region to usage stats query with the specified region in the parameter #443

Closed
5 tasks done
sashachabin opened this issue Aug 19, 2022 · 1 comment
Closed
5 tasks done
Assignees

Comments

@sashachabin
Copy link
Collaborator

sashachabin commented Aug 19, 2022

It seems that a rather particular scenario, when the user writes >0.1, selects a region. And we need to automatically add the region to users query.

  • Add in .. region to the query if specified region parameter
  • Return updated query in JSON response
  • Write tests getBrowsers(query, region)
    • ShoulddeepEqual:
      await getBrowsers('>0.1% and <10%, dead', 'FR'),
      await getBrowsers('>0.1% in FR and <10% in FR, dead', 'FR')
    • Queries should show different coverage
      await getBrowsers('>0.1% and supports es6-module', 'alt-as')
      await getBrowsers('>0.1% and supports es6-module', 'IT')

Errors with displayed versions

https://browsersl.ist/?q=%3E1%25&region=alt-as (bug)

https://browsersl.ist/?q=%3E1%25+in+alt-as&region=alt-as (good)

@sashachabin sashachabin self-assigned this Aug 19, 2022
@sashachabin sashachabin changed the title Add in region to >0% with the specified region in the parameter Add in region to usage stats query with the specified region in the parameter Aug 19, 2022
@sashachabin sashachabin changed the title Add in region to usage stats query with the specified region in the parameter Auto add in region to usage stats query with the specified region in the parameter Aug 19, 2022
@sashachabin
Copy link
Collaborator Author

New idea
#446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant