Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate fails when output_single_file_only option set to False #69

Open
gwaybio opened this issue May 29, 2021 · 1 comment
Open

Aggregate fails when output_single_file_only option set to False #69

gwaybio opened this issue May 29, 2021 · 1 comment
Labels
Method Development These issues discuss method-based improvements and testing

Comments

@gwaybio
Copy link
Member

gwaybio commented May 29, 2021

In an experiment with >1,000 sites, the aggregate recipe step fails quietly. We do not observe any errors, but the recipe next step is nevertheless performed and not surprisingly fails.

This may be a compute size issue, but it silently failing is still concerning and we should address.

One option is to aggregate each site independently, and then, with the number of single cells per perturbation, weight the aggregated contribution proportionally to cell count. I describe this option in #57 - time to revisit!

@gwaybio gwaybio added the Method Development These issues discuss method-based improvements and testing label May 29, 2021
@gwaybio
Copy link
Member Author

gwaybio commented May 29, 2021

One option is to aggregate each site independently, and then, with the number of single cells per perturbation, weight the aggregated contribution proportionally to cell count.

This is only an approximation to the aggregation and cannot be exactly equivalent to aggregating all single cells at once.

In #70 I implement an approx_aggregate_piecewise() function that does precisely the above. Currently, I have it set to only approx aggregate on sites, but we might explore aggregating based on wells as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Method Development These issues discuss method-based improvements and testing
Projects
None yet
Development

No branches or pull requests

1 participant