From 4eb285cdfce49ff0ba104a31d1fe05334717f4f1 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Sat, 24 Jul 2021 14:43:47 -0700 Subject: [PATCH] Remove XXX and TODO markers --- src/cli.rs | 2 -- src/lib.rs | 3 --- tests/common/mod.rs | 2 -- 3 files changed, 7 deletions(-) diff --git a/src/cli.rs b/src/cli.rs index 25214c2..c667d41 100644 --- a/src/cli.rs +++ b/src/cli.rs @@ -127,7 +127,6 @@ impl Action { }) } } - // TODO: Figure out how to store the result of the version_from_flag() call. Some(version) if version_from_flag(version).is_some() => { Ok(Action::Execute { launcher_path, @@ -211,7 +210,6 @@ fn relative_venv_path(add_default: bool) -> PathBuf { /// existence of the `VIRTUAL_ENV` environment variable. fn venv_executable_path(venv_root: &str) -> PathBuf { PathBuf::from(venv_root).join(relative_venv_path(false)) - // XXX: Do a is_file() check first? } fn activated_venv() -> Option { diff --git a/src/lib.rs b/src/lib.rs index 6f13540..049ecc5 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -146,7 +146,6 @@ impl Display for RequestedVersion { impl FromStr for RequestedVersion { type Err = Error; - // XXX Require `python` as a prefix? fn from_str(version_string: &str) -> Result { if version_string.is_empty() { Ok(Self::Any) @@ -307,8 +306,6 @@ impl ExactVersion { }) } - // XXX from_shebang()? - /// Tests whether this [`ExactVersion`] satisfies the [`RequestedVersion`]. /// /// # Examples diff --git a/tests/common/mod.rs b/tests/common/mod.rs index fa6b1f6..b4b61c3 100644 --- a/tests/common/mod.rs +++ b/tests/common/mod.rs @@ -26,7 +26,6 @@ impl EnvVarState { } } - // XXX This attribute shouldn't be needed; side-effect of only being used in tests? #[allow(dead_code)] pub fn empty() -> Self { let mut state = Self::new(); @@ -63,7 +62,6 @@ impl Drop for CurrentDir { } impl CurrentDir { - // XXX This attribute shouldn't be needed; side-effect of only being used in tests? #[allow(dead_code)] pub fn new() -> Self { let _original_dir = env::current_dir().unwrap();