From f8de8b413ade772566b9d95b08ee16d92354cc49 Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Sat, 10 Aug 2024 00:21:50 +0700 Subject: [PATCH 1/4] Fix codeowners order. --- .github/CODEOWNERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7f8bfc07..67f5d562 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,2 +1,4 @@ -seed/seed.json @brave/uplift-approvers +# The order is important. The last matching pattern takes the most precedence. + * @brave/griffin-maintainers +seed/seed.json @brave/uplift-approvers From c0304395463cfdbaaafb790de5dc36fe3340c1e2 Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Sat, 10 Aug 2024 00:24:18 +0700 Subject: [PATCH 2/4] Start from the root. --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 67f5d562..10148ce2 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,4 @@ # The order is important. The last matching pattern takes the most precedence. * @brave/griffin-maintainers -seed/seed.json @brave/uplift-approvers +/seed/seed.json @brave/uplift-approvers From d8e7c6735f065ed11576acc023ed678f82f5d73c Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Sat, 10 Aug 2024 00:26:51 +0700 Subject: [PATCH 3/4] Do not indent owners. --- .github/CODEOWNERS | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 10148ce2..cc2948b5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,5 @@ # The order is important. The last matching pattern takes the most precedence. -* @brave/griffin-maintainers -/seed/seed.json @brave/uplift-approvers +* @brave/griffin-maintainers + +/seed/seed.json @brave/uplift-approvers From dc3689dc5a58c35ba66e1eb0c4a83265349b8271 Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Sat, 10 Aug 2024 00:40:40 +0700 Subject: [PATCH 4/4] Add few comments to describe codeowners decision. --- .github/CODEOWNERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cc2948b5..4420cad4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,5 +1,8 @@ # The order is important. The last matching pattern takes the most precedence. +# Griffin maintainers are responsible for all machinery in this repository. * @brave/griffin-maintainers +# The seed file is owned by the uplift team as any change to it directly affects +# public builds. It's important to update the seed in a controlled manner. /seed/seed.json @brave/uplift-approvers