From fb0fcc859a5995b7ba3d93037878425caf5f8f8b Mon Sep 17 00:00:00 2001
From: Polina Bungina <27892524+hughcapet@users.noreply.github.com>
Date: Fri, 22 Nov 2024 14:29:59 +0100
Subject: [PATCH] Release v4.0.4 (#3221)

* Release v4.0.4

- Increase version
- Use latest pyright
- Add RNs
---
 .github/workflows/tests.yaml |  2 +-
 docs/releases.rst            | 34 ++++++++++++++++++++++++++++++++++
 patroni/version.py           |  2 +-
 3 files changed, 36 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
index f0f6d88c7..6f084e0db 100644
--- a/.github/workflows/tests.yaml
+++ b/.github/workflows/tests.yaml
@@ -186,7 +186,7 @@ jobs:
 
     - uses: jakebailey/pyright-action@v2
       with:
-        version: 1.1.385
+        version: 1.1.389
 
   ydiff:
     name: Test compatibility with the latest version of ydiff
diff --git a/docs/releases.rst b/docs/releases.rst
index 616a98ea8..b04cfd695 100644
--- a/docs/releases.rst
+++ b/docs/releases.rst
@@ -3,6 +3,40 @@
 Release notes
 =============
 
+Version 4.0.4
+-------------
+
+Released 2024-11-22
+
+**Stability improvements**
+
+- Add compatibility with the ``py-consul`` module (Alexander Kukushkin)
+
+  ``python-consul`` module is unmaintained for a long time, while ``py-consul`` is the official replacement. Backward compatibility with python-consul is retained.
+
+- Add compatibility with the ``prettytable>=3.12.0`` module (Alexander Kukushkin)
+
+  Address deprecation warnings.
+
+- Compatibility with the ``ydiff==1.4.2`` module (Alexander Kukushkin)
+
+  Fix compatibility issues for the latest version, constrain version in ``requirements.txt``, and introduce latest version compatibility test.
+
+**Bugfixes**
+
+- Run ``on_role_change`` callback after a failed primary recovery (Polina Bungina, Alexander Kukushkin)
+
+  Additionally run ``on_role_change`` callback for a primary that failed to start after a crash to increase chances the callback is executed, even if the further start as a replica fails.
+
+- Fix a thread leak in ``patronictl list -W`` (Alexander Kukushkin)
+
+  Cache DCS instance object to avoid thread leak.
+
+- Ensure only supported parameters are written to the connection string (Alexander Kukushkin)
+
+  Patroni used to pass parameters introduced in newer versions to the connection string, which had been leading to connection errors.
+
+
 Version 4.0.3
 -------------
 
diff --git a/patroni/version.py b/patroni/version.py
index dc6b34b39..26b4b6679 100644
--- a/patroni/version.py
+++ b/patroni/version.py
@@ -2,4 +2,4 @@
 
 :var __version__: the current Patroni version.
 """
-__version__ = '4.0.3'
+__version__ = '4.0.4'