Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

malicious height packet #60

Open
bradyrussell opened this issue Aug 6, 2021 · 1 comment
Open

malicious height packet #60

bradyrussell opened this issue Aug 6, 2021 · 1 comment

Comments

@bradyrussell
Copy link
Owner

by sending a height packet with an arbitrarily high number, you could cause the current implementation of the node to wait indefinitely for a block of that height
@bradyrussell
Copy link
Owner Author

bradyrussell commented Aug 6, 2021 •
edited
Loading

is the height and height request communication really necessary? I'm thinking if we remove it and just immediately send

SYNC <current height>

it would be all the same but without this exploit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradyrussell