Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tracks in lib added to current playlist on lost focus #105

Open
littlecoce opened this issue Aug 16, 2023 · 3 comments
Open

All tracks in lib added to current playlist on lost focus #105

littlecoce opened this issue Aug 16, 2023 · 3 comments

Comments

@littlecoce
Copy link

Hey all,

Using: Arch Linux
Sway 1.8.1
Alacritty 0.12.2 (9d9982df)
vimpc 0.09.1 [95ad78d]
mpd 0.23.13

When opening vimpc in alacritty, on lost focus all tracks are added to my playlist. This happens no matter in which tab I'm currently in. journalctl does not log anything related and I don't find any other log files.

Tests with kitty do NOT show this behavior.

Is this the right place for this report?

@iyra
Copy link

iyra commented Sep 10, 2023

I think I'm also facing this issue (using Arch and xmonad though) - couldn't figure out why this was happening, but it's frustrating, especially given that my library is quite large.

@pasha-dushny
Copy link

Same issue with i3wm on Archlinux

@nathan-whittington
Copy link

nathan-whittington commented Apr 26, 2024

This one has been bugging me for a while. I don't understand the code well enough to make an official PR but this fixed the issue for me:

diff --git a/src/mpdclient.cpp b/src/mpdclient.cpp
index a4516ca..c462e31 100644
--- a/src/mpdclient.cpp
+++ b/src/mpdclient.cpp
@@ -1389,7 +1389,7 @@ void Client::AddAllSongs()
       if (Connected() == true)
       {
          Debug("Client::Add all songs");
-         mpd_send_add(connection_, "");
+         // mpd_send_add(connection_, "");
       }
       else
       {

I mainly use vimpc as a way to view my current playlist so who knows what I broke with this change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants