Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no authentification after migration. oidcIssuer must end with '/' in CSS #5

Open
bourgeoa opened this issue Nov 20, 2024 · 3 comments · Fixed by #6
Open

no authentification after migration. oidcIssuer must end with '/' in CSS #5

bourgeoa opened this issue Nov 20, 2024 · 3 comments · Fixed by #6

Comments

@bourgeoa
Copy link
Owner

bourgeoa commented Nov 20, 2024

see solid-contrib/pivot#28

Not related with mashlib 1.10.0

The issue is that /profile/card oidc issuer does not end with slash in NSS
The slash is needed in CSS.

solid:oidcIssuer is mandatory per https://solid.github.io/solid-oidc/#webid-profile (related to nodeSolidServer/node-solid-server#1639 )

The slash is not in the spec

@michielbdejong
Copy link

So should we just add the slash in people's profile cards where it's not present?

@bourgeoa
Copy link
Owner Author

Technically this can be done.
It is a regression on spec support.

@bourgeoa bourgeoa changed the title no authentification after migration no authentification after migration. oidcIssuer must end with '/' in CSS Nov 24, 2024
@bourgeoa bourgeoa linked a pull request Nov 24, 2024 that will close this issue
@bourgeoa bourgeoa reopened this Dec 13, 2024
@bourgeoa
Copy link
Owner Author

Do not cover all cases due to replace string and not update store.
May be found all string replacement combination in https://solidcommunity.net or use the RDF store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants