Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support email and phone types when type keyword is omitted #67

Open
ManolisKoufidakis opened this issue Jul 5, 2024 · 3 comments
Open

Support email and phone types when type keyword is omitted #67

ManolisKoufidakis opened this issue Jul 5, 2024 · 3 comments

Comments

@ManolisKoufidakis
Copy link

Hi,

I see that when an email or phone is included in the vcard without the "type" keyword in its metadata then the metadata are lost. Below are some examples about my point:

TEL;CELL:+306971212122
EMAIL;WORK;INTERNET:[email protected]

In this cases the type of the email or phone are not properly identified. I would like to support these cases since they are valid vcard notations. I can open a PR for this if you have no objections.

Thank you
@bolorundurowb
Copy link
Owner

@ManolisKoufidakis the format you described is supported on vCard versions 2.1 and 3.0 but is not valid for vCard 4. What version of vCard is the file that contains these lines?

@ManolisKoufidakis
Copy link
Author

It was a v3 vcard.

@bolorundurowb
Copy link
Owner

bolorundurowb commented Sep 28, 2024 •
edited
Loading

@ManolisKoufidakis please open a PR if you can

ManolisKoufidakis pushed a commit to ManolisKoufidakis/vCardLib that referenced this issue Sep 30, 2024
bolorundurowb#67: Suport data types for emails without the type keyword.
242ed0a
ManolisKoufidakis pushed a commit to ManolisKoufidakis/vCardLib that referenced this issue Sep 30, 2024
bolorundurowb#67: Suport data types for emails without the type keyword.
b40ef6f
ManolisKoufidakis pushed a commit to ManolisKoufidakis/vCardLib that referenced this issue Sep 30, 2024
bolorundurowb#67: Support data types for phones without the type keyw…
db94ca3 
…ork.
ManolisKoufidakis pushed a commit to ManolisKoufidakis/vCardLib that referenced this issue Sep 30, 2024
bolorundurowb#67: Support data types for phones without the type keyw…
68f1714 
…ork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ManolisKoufidakis @bolorundurowb