Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sepolia L2 issue #348

Closed
boyuan-chen opened this issue Feb 16, 2024 · 15 comments
Closed

Sepolia L2 issue #348

boyuan-chen opened this issue Feb 16, 2024 · 15 comments
Assignees
Labels
S 2 day

Comments

@boyuan-chen
Copy link
Contributor

boyuan-chen commented Feb 16, 2024

  1. If you cancel the transaction, it skips the current step and goes the next one.
  2. If I close the modal in the middle of the process, where can I find it back?
  3. The history section doesn't work.
@sk-enya
Copy link
Collaborator

sk-enya commented Feb 16, 2024

@wsdt can you please give more details on points 2/ & 3/?
How are we going to handle the pending txs on history?

@wsdt
Copy link
Contributor

wsdt commented Feb 16, 2024

  1. If I close the modal in the middle of the process, where can I find it back?

The gateway picks up where you left of in the background and shows a notification for the user to proceed. Furthermore, the user can continue on the history page, there is a button if there are actions pending.

  1. What doesn't work? @sk-enya could this be related to the new sepolia/goerli upgrade?

@boyuan-chen
Copy link
Contributor Author

The exit amount and token is not correct.
image

@boyuan-chen
Copy link
Contributor Author

Can we reduce the loading time for the history page? Something goes wrong. The exit transaction popped up after I picked the From and To networks.

@boyuan-chen
Copy link
Contributor Author

The metamask doesn't pop up when I try to prove the withdrawal.
image

@sk-enya
Copy link
Collaborator

sk-enya commented Feb 22, 2024

@boyuan-chen all the issues fixes except the Can we reduce the loading time for the history page? Something goes wrong. The exit transaction popped up after I picked the From and To networks. we will consider in the another issue

@sk-enya
Copy link
Collaborator

sk-enya commented Feb 22, 2024

Closing as all the changes has been done with
#350

@sk-enya sk-enya closed this as completed Feb 22, 2024
@boyuan-chen
Copy link
Contributor Author

@sk-enya @wsdt new issues:

  1. I have submitted the proof first. However, I can't claim the withdrawal. The metamask didn't pop up.
  2. When I reopen the modal, it goes back to the submit proof step.
image

@sk-enya sk-enya reopened this Feb 26, 2024
@sk-enya
Copy link
Collaborator

sk-enya commented Feb 28, 2024

@wsdt looks like when user comes back to the modal above after proving withdrawal the claim button won't work as value of latestLogs always null if we directly open the modal in proven state.

@sk-enya
Copy link
Collaborator

sk-enya commented Feb 28, 2024

Can you please look into? here is the updated PR with other broken changes for bridging & history page.

@wsdt
Copy link
Contributor

wsdt commented Feb 28, 2024

does your PR fix the issue above? @sk-enya

@sk-enya
Copy link
Collaborator

sk-enya commented Feb 28, 2024

@wsdt updated pull request with changes done as points

@sk-enya
Copy link
Collaborator

sk-enya commented Feb 28, 2024

@wsdt the question is about the claim features when you open the already proven transactions which is not getting triggered!

It's seems that flow has not be change while adding support for the goerli for sure.

@sk-enya
Copy link
Collaborator

sk-enya commented Mar 6, 2024

@sk-enya @wsdt new issues:

  1. I have submitted the proof first. However, I can't claim the withdrawal. The metamask didn't pop up.
  2. When I reopen the modal, it goes back to the submit proof step.
image

Added fix for this in PR #378

@sk-enya sk-enya added the S 2 day label Mar 11, 2024
@sk-enya
Copy link
Collaborator

sk-enya commented Mar 12, 2024

Changes has been taken care so closing the issue, please feel free to create new or open open the issue again!

@sk-enya sk-enya closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S 2 day
Projects
None yet
Development

No branches or pull requests

3 participants