Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BootstrapBuilder should be defined as a provider #47

Open
Jire opened this issue Dec 8, 2024 · 0 comments
Open

BootstrapBuilder should be defined as a provider #47

Jire opened this issue Dec 8, 2024 · 0 comments

Comments

@Jire
Copy link

Jire commented Dec 8, 2024

BootstrapBuilder while possible to configure some params, does not allow the functionality to entirely create the ServerBootstrap yourself by passing in already-existing EventLoopGroups. This means that when trying to utilize multiple RSProt NetworkService in a single application, you cannot re-use your EventLoopGroup, leading to poor performance.

Something like a BootstrapProvider interface should be introduced, allowing the API user to provide their own ServerBootstrap if they choose. BootstrapBuilder would then be renamed BootstrapProviderBuilder and provide from the build result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant