Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Profanity Filter #40

Open
Z-Kris opened this issue Oct 24, 2024 · 0 comments
Open

Support for Profanity Filter #40

Z-Kris opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Z-Kris
Copy link
Contributor

Z-Kris commented Oct 24, 2024

Note

This issue is not about introducing an actual profanity filter to RSProt, but rather supporting showing different overhead chat on players depending on if they have a profanity filter enabled or not!

As it stands, RSProt does not offer a way for one to show a different overhead string depending on their profanity filter settings. The overhead chat people see must be identical between all of them, which is a problem for anyone wanting to implement a non-forced filter that depends on the player's own settings.

We need to allow passing two overhead chats to the chat() function, one for players who have profanity filter enabled, and one for those who do not have it enabled. RSProt should then precalculate both variants of the buffer once, regardless of how many players are observing that. We should make sure to avoid calculating these buffers on demand as they use Huffman encoding and it isn't as cheap to execute as say, hits.

In addition to the two strings passed into the function, we need a 'profanityFilter' boolean on avatars that informs RSProt which variant of the encoded buffer to send for this player.

@Z-Kris Z-Kris added the enhancement New feature or request label Oct 24, 2024
@Z-Kris Z-Kris self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant