Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the OneOfEverythingDevice to check the assert functions #707

Closed
coretl opened this issue Dec 13, 2024 · 2 comments · Fixed by #711
Closed

Use the OneOfEverythingDevice to check the assert functions #707

coretl opened this issue Dec 13, 2024 · 2 comments · Fixed by #711
Assignees
@jsouter

Comments

@coretl
Copy link
Collaborator

coretl commented Dec 13, 2024

So that every type is checked.

The Device will need extending so that all Signals will appear in both Read and Configure. Possibly choosing which via an init arg.

Acceptance Criteria

  • All types of signal and value are testing when testing the assert_* functions
@jsouter
Copy link
Contributor

jsouter commented Dec 16, 2024

Should I change assert_value to work with arrays?

@coretl
Copy link
Collaborator Author

coretl commented Dec 16, 2024

Yes please

@jsouter jsouter mentioned this issue Dec 18, 2024
Merged
@jsouter jsouter linked a pull request Dec 18, 2024 that will close this issue
Expand assert_* functions to work with all signal types #711
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsouter jsouter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand assert_* functions to work with all signal types bluesky/ophyd-async
2 participants
@coretl @jsouter