Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable hardcoded 'cookie' package version #43

Open
sethidden opened this issue Nov 15, 2024 · 1 comment
Open

Vulnerable hardcoded 'cookie' package version #43

sethidden opened this issue Nov 15, 2024 · 1 comment

Comments

@sethidden
Copy link

sethidden commented Nov 15, 2024

You are using a cookie package version vulnerable to GHSA-pxg6-pf52-xh8x

"cookie": "0.4.1",

Because you've hardcoded the dep version to 0.4.1 I can't update in my lockfile to get this fixed on my side. I don't understand why did you do it - does spa-sdk work ONLY on 0.4.1 and no other version?

Please release a new version and don't hardcode package versions and use ^0.7.0 instead of 0.7.0

@sethidden sethidden changed the title Vulnerable 'cookie' package version Vulnerable hardcoded 'cookie' package version Nov 15, 2024
@joerideg
Copy link
Contributor

hi @sethidden ,

We have always pinned our dependency versions in the package.json in order to prevent unwanted changes to be installed onto others systems as dependency versions are released, not everyone follows semver and humans sometimes make mistakes and vulnerabilities can creep into releases. So we prefer to check ourselves and release a new version after verifying and running our e2e tests. We will discuss if this restriction is still worth it in todays world.

After all this is flagged as a security issue and we should update this asap, so the other way around is a valid argument too.

We will fix this security issue (among others) and release a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants