From 771a7cf3f119f3597c172b1485a9755ed828b7d2 Mon Sep 17 00:00:00 2001
From: David <dgx.arnold@gmail.com>
Date: Fri, 25 Oct 2024 14:41:20 +0200
Subject: [PATCH] build: pin node to version 20 (as tested in upstream
 releases)

---
 src/overlays/frappe/frappe.nix  | 2 +-
 src/overlays/tools/mkAssets.nix | 4 ++--
 src/shell.nix                   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/overlays/frappe/frappe.nix b/src/overlays/frappe/frappe.nix
index 27fe843..0805286 100644
--- a/src/overlays/frappe/frappe.nix
+++ b/src/overlays/frappe/frappe.nix
@@ -28,7 +28,7 @@ buildPythonPackage rec {
         which # pdfkit detects wkhtmltopdf this way
         gzip # for manual backups from the frappe ui
         bash
-        nodejs_18
+        nodejs_20
         redis
       ];
       test-dependencies = with python.pkgs; [
diff --git a/src/overlays/tools/mkAssets.nix b/src/overlays/tools/mkAssets.nix
index 0b8ce9a..2782d28 100644
--- a/src/overlays/tools/mkAssets.nix
+++ b/src/overlays/tools/mkAssets.nix
@@ -2,7 +2,7 @@
 {
   runCommand,
   path,
-  nodejs_18,
+  nodejs_20,
   yarn,
   nodePackages,
   emptyFile,
@@ -36,7 +36,7 @@ in
       pname = pname + "_";
       inherit src version;
       nativeBuildInputs = [
-        nodejs_18
+        nodejs_20
         (yarn.overrideAttrs {withNode = false;})
         yarn2nix-moretea.fixup_yarn_lock
       ];
diff --git a/src/shell.nix b/src/shell.nix
index 57e7788..89c2234 100644
--- a/src/shell.nix
+++ b/src/shell.nix
@@ -288,7 +288,7 @@ in {
           (devPackage pkgs.bench)
           (devPackage pkgs.apps)
           (devPackage pkgs.analyze-prs)
-          (devPackage pkgs.nodejs_18)
+          (devPackage pkgs.nodejs_20)
           (devPackage (pkgs.yarn.overrideAttrs {withNode = false;}))
         ];
       };