Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent version flag in CommandApp vs CommandIOApp #299

Open
alexcardell opened this issue May 21, 2021 · 1 comment · May be fixed by #300
Open

Inconsistent version flag in CommandApp vs CommandIOApp #299

alexcardell opened this issue May 21, 2021 · 1 comment · May be fixed by #300

Comments

@alexcardell
Copy link

This is a tiny issue, but the CommandIOApp version flag has a short flag and the CommandApp does not.

Personally, I'd prefer a short flag for verbosity over version, so it'd be good to make it configurable with a non-breaking default to avoid any breaking changes in people's scripts.

alexcardell added a commit to alexcardell/decline that referenced this issue May 21, 2021
@alexcardell alexcardell linked a pull request May 21, 2021 that will close this issue
@bkirwi
Copy link
Owner

bkirwi commented May 30, 2021

Nice catch! I agree that we really shouldn't be adding a short flag by default there... it's nonstandard and conflicts with other common usages.

I'll need to be careful about backwards compatability here, so this might need to wait for a larger release. I'll have a look. (But in any case will merge it sooner or later - thank you for the PR!)

If this is blocking you (or annoying any other reader) in the meantime, note that it's possible to add your own version flag to the command you pass in, as in myCommand orElse Opts.flag("version", ...).map(printVersion) or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants