Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (or update) LightningInvoice type #12

Open
brh28 opened this issue Sep 23, 2024 · 0 comments
Open

Remove (or update) LightningInvoice type #12

brh28 opened this issue Sep 23, 2024 · 0 comments

Comments

@brh28
Copy link

brh28 commented Sep 23, 2024

When importing types into my application, I see two options for LightningInvoice:
1.

import { LightningInvoice } from "bitvora/dist/lightning_invoice";
import { LightningInvoice} from "bitvora/dist/types";

These two types differ slightly. The createLightningInvoice function returns a type compatible with option 1, but most of the exported types seem to come from option 2. Correct me if I'm wrong, it seems like the export from option 2 should be updated to reflect the return of the createLightningInvoice function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant