Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wrapt #49

Open
interrogator opened this issue Feb 4, 2019 · 2 comments
Open

Use wrapt #49

interrogator opened this issue Feb 4, 2019 · 2 comments

Comments

@interrogator
Copy link
Contributor

the wrapt module provides some helper decorators for making class decorators that attach to all methods. we do some creepy stuff to make this work, so it'd be better to rely on a well-known implementation.

@interrogator
Copy link
Contributor Author

So last time we looked at this, we realised it's actually a bit hard to do, though it likely is the best way forward. I won't be even attempting this in the near future, but we can leave this open.

@hukkin
Copy link
Contributor

hukkin commented May 6, 2019

Yeah I tried once (unfortunately didnt seem to push the code anywhere so can't find it now). Had an implementation but still had some of the tests failing. So yes, this might be harder than it sounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants