Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDK Node + BDK #620

Open
reez opened this issue Nov 4, 2024 · 6 comments
Open

LDK Node + BDK #620

reez opened this issue Nov 4, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@reez
Copy link
Collaborator

reez commented Nov 4, 2024

Describe the bug

i've just updated to v0.4.1 in my swift app but my project won't build, xcode complains 'RustBuffer::capacity' from module 'LDKNodeFFI.LDKNodeFFI' is not present in definition of 'struct RustBuffer' in module 'bdkFFI.bdkFFI'
ldknodebdk

To Reproduce
Import BDK and LDK Node into the same project.

Expected behavior
Project should build.

Build environment

  • BDK tag/commit:
  • OS+version:
  • Rust/Cargo version:
  • Rust/Cargo target:

Additional context

@reez reez added the bug Something isn't working label Nov 4, 2024
@reez
Copy link
Collaborator Author

reez commented Nov 4, 2024

It could be that LDK node and BDK are currently incompatible due to re-exporting the same types with different UniFFI versions

@reez
Copy link
Collaborator Author

reez commented Nov 4, 2024

I was unable to reproduce with this setup Xcode 16.1:

I chose that setup to test pre-1.0 and post-1.0 in combination with the referenced ldk-node 0.4.1.

post_1-0 pre_1-0

@tnull
Copy link

tnull commented Nov 6, 2024

Btw, likely unrelated, but we didn't release Swift bindings for LDK Node 0.4.1 only then for the newest 0.4.2.

@reez
Copy link
Collaborator Author

reez commented Nov 6, 2024

Btw, likely unrelated, but we didn't release Swift bindings for LDK Node 0.4.1 only then for the newest 0.4.2.

Good additional note on reproducing the issue that was reported by a user, Swift bindings for LDK Node 0.4.1 are actually just 0.4.0, so if user was pulling in 0.4.1 it would have just used 0.4.0. I'm still unable to reproduce the issue reported by the user who mentioned they were using LDK Node 0.4.1 and BDK, but maybe I haven't tried the same BDK version they are using.

Adding screenshot of 0.4.1 having Package.swift tag 0.4.0:

Screenshot 2024-11-06 at 6 50 32 AM

@tnull
Copy link

tnull commented Nov 6, 2024

Good additional note on reproducing the issue that was reported by a user, Swift bindings for LDK Node 0.4.1 are actually just 0.4.0

Yes, as said above, we didn't release 0.4.1 for Swift as by the time we came around to do so, we had to push out a fix with 0.4.2 so didn't make sense to do a release for a known-to-be-buggy version.

@reez
Copy link
Collaborator Author

reez commented Nov 6, 2024

Good additional note on reproducing the issue that was reported by a user, Swift bindings for LDK Node 0.4.1 are actually just 0.4.0

Yes, as said above, we didn't release 0.4.1 for Swift as by the time we came around to do so, we had to push out a fix with 0.4.2 so didn't make sense to do a release for a known-to-be-buggy version.

Makes sense

@thunderbiscuit thunderbiscuit added this to the 1.0 Release milestone Nov 14, 2024
@thunderbiscuit thunderbiscuit removed this from the 1.0.0 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants