Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency signature verification for bdk-swift #368

Open
reez opened this issue Jun 9, 2023 · 5 comments
Open

Dependency signature verification for bdk-swift #368

reez opened this issue Jun 9, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@reez
Copy link
Collaborator

reez commented Jun 9, 2023

Describe the enhancement
Digitally sign xcframework for bdk-swift.

Use case
Developers using bdk-swift will be able to verify xcframework is digitally signed.

Additional context
In Xcode 15 Apple will show whether the framework has been digitally signed or not.

Currently the bdk-swift xcframework would look like this in Xcode 15, "unsigned":

Screenshot 2023-06-09 at 10 36 16 AM

Apple references:

  • WWDC23 session video
  • Apple Developer Documentation article
@reez reez added the enhancement New feature or request label Jun 9, 2023
@thunderbiscuit
Copy link
Member

Cool! Let me know if you need the GPG keys for the signature (is it done in the CI? that's what it is for the Kotlin libraries).

@reez
Copy link
Collaborator Author

reez commented Jun 9, 2023

Cool! Let me know if you need the GPG keys for the signature (is it done in the CI? that's what it is for the Kotlin libraries).

Sweet! Yeah it looks just like a one line command we can do in the CI. I’ll go see what you all do in Kotlin since you do it there, just because I’m interested in how that works-

@reez
Copy link
Collaborator Author

reez commented Nov 1, 2023

I think the only hangup here is the need to have an Apple Distribution certificate to sign with (which I'm not sure if we have or not)

@reez
Copy link
Collaborator Author

reez commented Apr 30, 2024

We have an Apple Developer account now so we should have all the pieces in place to do this when it's risen to the top of the priority list-

@thunderbiscuit
Copy link
Member

Sounds good let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants