Support ToMany in PrincipalsMixin

[odcinek]

PrincipalsMixin seems to support ToOne fields, but ToMany is left unimplemented . I haven't found a good way to express it in flask-principal terms, without creating a Need instance for every relation member.

@lyschoening How would you approach this? Happy to take a shot at implementing this.

[lyschoening]

Ah, I left this out when I implemented this because I could not think of any immediate use case.
Frankly, I still cannot think of any. Permissions are usually set up in a tree structure. Do you have an example scenario?

Regarding the implementation: If we say that "any" of the items in the relationship needs to fulfil the need, then it might be enough to replace isinstance(field, ToOne) with isinstance(field, (ToOne, ToMany)). When the query is built, PrincipalsMixin calls SQLAlchemyManager._expression_for_join(), which will automatically determine the correct join to use.

It is possible that I am overlooking something. It would definitely need some tests. Since I unwisely wrote all the tests against a single database model it might also be necessary to add a new TestCase.

[goshasawicka]

Hi. One of the examples might be a user who is a member of a group.
Case scenario: Restrict updates on Group resource to its members according to the model below.

class User(db.Model):
    id = db.Column(db.Integer, primary_key=True)
    email = db.Column(db.String(120), unique=True)
    group_id = db.Column(db.Integer, db.ForeignKey('group.id'))

class Group (db.Model):
    id = db.Column(db.Integer, primary_key=True)
    name = db.Column(db.String(140))
    members = db.relationship('User', backref='group')

[odcinek]

@lyschoening I managed to make it work, I'll send a PR once I figure the tests

[lyschoening]

@odcinek Ok, thanks for doing this!

@Patyk That makes sense. Please note, if it is only a handful of group memberships I would recommend fetching them as ItemNeed when the identity is loaded.

[jas32096]

@odcinek Any update on your progress? I'd like to use this in my own project

[galuszkak]

I think I have really similar use case here. @odcinek @Patyk did you manage to create something for this, or maybe you can share Your solution for that problem? I will greatly appreciate any insights on that :).