Replies: 1 comment
-
It is about naming, and it's not only that. It's also about the impact that it can have on diffs. For example, you have a module of 1k LOC, where no properties were required. Then, you make a PR that adds a property that requires quotes, and because of that all properties across 1k LOC change. You'll have formatting changes scattered, plus your changes. This isn't what a formatter should do, so I don't see enough value to have this option. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I brought this up in the Discord server around a month ago though I'd like to bring it here for a more formal discussion on the merits of such a rule. The closest I got to an answer was the following from @Conaclos:
So it seems to be an issue with the naming, not the concept, of the rule. I'm wondering if seeing as that is the case renaming this option for the rule could be a viable strategy? E.g.
all-or-none
(all use quotes or none use quotes),all-if-some
(all use quotes if some initially use quotes),all-if-present
(all use quotes if quotes are present initially)...I'd really love to see this change in Biome, and I'm sure I'm not the only one: according to https://github.com/search?q=%22quoteProps%22:+%22consistent%22&type=code & https://github.com/search?q=quoteProps:+%22consistent%22&type=code close to fifteen thousand configuration files are using this behavior.
Beta Was this translation helpful? Give feedback.
All reactions