Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET to /management/plugins returns nothing useful #708

Closed
tiberio-baptista opened this issue Dec 16, 2024 · 1 comment · Fixed by #709
Closed

GET to /management/plugins returns nothing useful #708

tiberio-baptista opened this issue Dec 16, 2024 · 1 comment · Fixed by #709

Comments

@tiberio-baptista
Copy link
Collaborator

          > I did find an issue with `ServicesServlet`: though I'm not sure that this was present before, I noticed that `GET /management/plugins/` returns the following response body:
{
  "isRunning": false,
  "port": -1,
  "autostart": false
}

Please confirm if this is expected. Otherwise, the PR is good and I can approve.

Personally, I would expect this endpoint to list the available plugins.

That is a curious finding. That endpoint is not part of the API, but it was probably captured by the service status servlet anyway, which tried to fetch the status of a service which does not exist.

This can be improved, but it is hardly problematic, nor does it not look like a regression from this PR.

Originally posted by @Enet4 in #705 (comment)

@Enet4
Copy link
Collaborator

Enet4 commented Dec 16, 2024

I had a second look at this. There were plans to support /management/plugins/ in the early v2 stages, but it was never done. It was only mapped into a stub in ServicesServlet, which in turn was designed to inspect and manipulate the status of DICOM services.

What we do have now is /plugins, which serves the purpose better.

I say we ditch the /management/plugins/ endpoint, so that it is not confused with the DICOM Storage and Query/Retrieval service status endpoints.

@tiberio-baptista tiberio-baptista changed the title GET to /management/plugins could return something useful GET to /management/plugins returns nothing useful Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants