From 3246c4d680a15c03d1817fe664490738a1a7f201 Mon Sep 17 00:00:00 2001 From: Charles Cowart Date: Thu, 19 Sep 2024 12:58:40 -0700 Subject: [PATCH 1/2] quick fixes --- sequence_processing_pipeline/Job.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sequence_processing_pipeline/Job.py b/sequence_processing_pipeline/Job.py index 1c1a7593..2d64b039 100644 --- a/sequence_processing_pipeline/Job.py +++ b/sequence_processing_pipeline/Job.py @@ -226,6 +226,9 @@ def wait_on_job_ids(self, job_ids, callback=None): # them before returning, optionally submitting callbacks for each # job-id. + # ensure all ids are strings to ensure proper working w/join(). + job_ids = [str(x) for x in job_ids] + def query_slurm(job_ids): # internal function query_slurm encapsulates the handling of # squeue. @@ -257,6 +260,8 @@ def query_slurm(job_ids): jobs = {} child_jobs = {} for job_id, unique_id, state in lines: + # ensure unique_id is of type string for downstream use. + unique_id = str(unique_id) jobs[unique_id] = state if unique_id != job_id: From 154d811cf0ce488a587e4283eb6a65b701da9d3e Mon Sep 17 00:00:00 2001 From: Charles Cowart Date: Tue, 1 Oct 2024 13:26:34 -0700 Subject: [PATCH 2/2] Removed unneeded change --- sequence_processing_pipeline/Job.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/sequence_processing_pipeline/Job.py b/sequence_processing_pipeline/Job.py index 2d64b039..b650543e 100644 --- a/sequence_processing_pipeline/Job.py +++ b/sequence_processing_pipeline/Job.py @@ -260,8 +260,6 @@ def query_slurm(job_ids): jobs = {} child_jobs = {} for job_id, unique_id, state in lines: - # ensure unique_id is of type string for downstream use. - unique_id = str(unique_id) jobs[unique_id] = state if unique_id != job_id: