Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #1

Open
bgpalmer opened this issue Oct 17, 2021 · 0 comments
Open

Review #1

bgpalmer opened this issue Oct 17, 2021 · 0 comments

Comments

@bgpalmer
Copy link

Looks good! I rewatched the lecture and your duplicate checks seem to add up. Specifically,

- Create tuple containing read_umi, bit16_flag, chromosome_name, adjusted_starting_position, and assign it to "key" variable. - Note: If bitwise flag of one read and bitwise flag of another read have the same bit-16 flag states (either BOTH have bit16_flag == TRUE, or BOTH have bit16_flag == FALSE), then they both have the same strandedness and possibly could be duplicates.

I also like how you export the data into the output sam file once moving on to the next umi. Sorting the file (UMI, chromosome, read position) before hand was a good call so you could implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant